feat: pre configure networksecurity/intercept samples #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@duvni do you expect samples in subfolders of networksecurity/ that will have owners other than pm2-team? Otherwise we should change the CODEOWNERS config for the top level folder, to reduce more PRs like this |
Contributor
Author
Yes, there are multiple other teams owning their own products under network security, not sure when they'll add doc samples, but let's keep it separated for them. |
glasnt
approved these changes
Mar 20, 2025
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a prerequisite for adding doc samples under
networksecurity/intercept, setting thepm2-teamgroup as owners.The members of this team are the owners for Network Security Integration product which includes both intercept and mirroring.
For reference, this is the PR that added mirroring: #806
Checklist
Readiness